Task-2 #1
Open
Task-2 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - " " | ||
| - - "arn:aws:iam::cloudfront:user/CloudFront Origin Access Identity" | ||
| - !Ref OriginAccessIdentity | ||
| Principal: "*" |
There was a problem hiding this comment.
Should we return back OAI configuration? Principal: "*" means that your bucket is gonna be public and available for anonymous. Limiting access by OAI gives access to a specific identity and closes bucket from the outside. https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-bucket-user-policy-specifying-principal-intro.html
mikhail-hatsilau
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Task:
https://github.com/EPAM-JS-Competency-center/cloud-development-course-initial/blob/main/2_serving_spa/task.md
2. What is done?
3. Links:
Manual deploy link S3: http://maksim-charnou-first-manual-aws-app.s3-website-eu-west-1.amazonaws.com/
Cloudfront auto deploy through serverless config: https://d1lxx2deqj5hgt.cloudfront.net/