Skip to content

Conversation

@jp-gouin
Copy link
Contributor

Description of the change

During Openldap init, this change does the TLS configuration before adding custom LDIFs.

Benefits

Using this helm chart, this change fixes a replication issue.
This chart allows users to spin up Openldap in K8S in a high availability mode. In a multi-node scenario, the first one starts without issue, other ones are in a race condition when setting up the tree (ldap_create_tree) and ldif ldap_add_custom_ldifs) due to the replication. This is an expected behaviour and once the replication kicks in all nodes are running.

By doing the TLS initialisation at the end of ldap_initialize() the TLS is not properly configured when Openldap restart.

Applicable issues

during openldap init, do the tls configuration before adding custom ldif

Signed-off-by: jpgouin <[email protected]>
@github-actions github-actions bot added openldap triage Triage is needed labels Dec 19, 2023
@github-actions github-actions bot requested a review from carrodher December 19, 2023 11:52
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 19, 2023
@github-actions github-actions bot removed the triage Triage is needed label Dec 19, 2023
@github-actions github-actions bot removed the request for review from carrodher December 19, 2023 12:30
@github-actions github-actions bot requested a review from FraPazGal December 19, 2023 12:30
Copy link
Contributor

@FraPazGal FraPazGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @jp-gouin!

@jpsn123
Copy link

jpsn123 commented Jul 24, 2024

@FraPazGal why this change do not apply to debian-12, moreover, are there any more pr have been lost.

@jp-gouin
this mistake waste of developers' hard work. hope to be valued by maintainer.

@jpsn123
Copy link

jpsn123 commented Jul 24, 2024

it seem to be reverted by stupid bot, #55570, and gratifying thing is no other pr have was lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openldap solved verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not compatible with Bitnami/openldap 2.6.6 ldif in /ldiffs not loaded

4 participants