Skip to content

Comments

use my namespace as key namespace#1867

Merged
alvneiayu merged 1 commit intobitnami-labs:mainfrom
farodin91:use-my-namespace-as-key-namespace
Jan 15, 2026
Merged

use my namespace as key namespace#1867
alvneiayu merged 1 commit intobitnami-labs:mainfrom
farodin91:use-my-namespace-as-key-namespace

Conversation

@farodin91
Copy link
Contributor

@farodin91 farodin91 commented Jan 14, 2026

Fixes #1862

@farodin91 farodin91 force-pushed the use-my-namespace-as-key-namespace branch from 7bbdb75 to 7438933 Compare January 14, 2026 13:38
@farodin91 farodin91 mentioned this pull request Jan 14, 2026
Closed
rickbrouwer
rickbrouwer suggested changes Jan 14, 2026
View reviewed changes
pkg/controller/main.go Outdated
kinformer := initSecretInformerFactory(clientset, keyNamespace, func(options *metav1.ListOptions) {
options.LabelSelector = keySelector.String()
}, f.WatchForSecrets)
sinformer := initSecretInformerFactory(clientset, namespace, tweakopts, f.SkipRecreate)
Copy link

@rickbrouwer rickbrouwer Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pass !f.SkipRecreate instead of f.SkipRecreate to make the logic consistent with the parameter name enabled?

Suggested change
sinformer := initSecretInformerFactory(clientset, namespace, tweakopts, f.SkipRecreate)
sinformer := initSecretInformerFactory(clientset, namespace, tweakopts, !f.SkipRecreate)

Copy link
Contributor Author

@farodin91 farodin91 Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@farodin91 farodin91 force-pushed the use-my-namespace-as-key-namespace branch from 7438933 to 42202eb Compare January 14, 2026 15:07
@farodin91
Copy link
Contributor Author

farodin91 commented Jan 15, 2026

@alvneiayu Would you like to review?

@alvneiayu
Copy link
Collaborator

alvneiayu commented Jan 15, 2026

thanks a lot for your contribution @farodin91

@alvneiayu alvneiayu merged commit 946bc04 into bitnami-labs:main Jan 15, 2026
15 checks passed
@armingerten
Copy link
Contributor

armingerten commented Feb 5, 2026

Is there already a plan to release a new version that includes this fix? (especially the !enabled fix)

@alvneiayu
Copy link
Collaborator

alvneiayu commented Feb 5, 2026

@armingerten the releases are done 1 per month. Next week, we are planning to have a release.

@armingerten
Copy link
Contributor

armingerten commented Feb 5, 2026

@alvneiayu, great! Thanks for the quick response 🙏

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 15, 2026
@tmeijn
build(deps): update bitnami-labs/sealed-secrets to v0.35.0
4d2d18a 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [bitnami-labs/sealed-secrets](https://github.com/bitnami-labs/sealed-secrets) | minor | `v0.34.0` → `v0.35.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>bitnami-labs/sealed-secrets (bitnami-labs/sealed-secrets)</summary>

### [`v0.35.0`](https://github.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0350)

[Compare Source](bitnami-labs/sealed-secrets@v0.34.0...v0.35.0)

- my namespace as key namespace ([#&#8203;1867](bitnami-labs/sealed-secrets#1867))
- Bump go 1.25.7 ([#&#8203;1880](bitnami-labs/sealed-secrets#1880))
- Update client-go and api 0.35.0 ([#&#8203;1868](bitnami-labs/sealed-secrets#1868))
- Bump golang.org/x/crypto from 0.46.0 to 0.47.0 ([#&#8203;1863](bitnami-labs/sealed-secrets#1863))
- Bump github.com/onsi/gomega from 1.38.3 to 1.39.0 ([#&#8203;1865](bitnami-labs/sealed-secrets#1865))
- Bump github.com/onsi/ginkgo/v2 from 2.27.3 to 2.27.5 ([#&#8203;1864](bitnami-labs/sealed-secrets#1864))
- Bump distroless/static from `4b2a093` to `cd64bec` in /docker ([#&#8203;1866](bitnami-labs/sealed-secrets#1866))
- Bump k8s.io/code-generator from 0.34.3 to 0.35.0 ([#&#8203;1858](bitnami-labs/sealed-secrets#1858))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMC4zIiwidXBkYXRlZEluVmVyIjoiNDMuMTAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvneiayu alvneiayu alvneiayu approved these changes

@agarcia-oss agarcia-oss Awaiting requested review from agarcia-oss agarcia-oss is a code owner

+1 more reviewer

@rickbrouwer rickbrouwer rickbrouwer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Controller watches for seal key secrets in all namespaces

4 participants

@farodin91 @alvneiayu @armingerten @rickbrouwer