Merged
Conversation
farodin91
force-pushed
the
add-watch-for-secrets
branch
3 times, most recently
from
2464dd3 to
e057153
Compare
Signed-off-by: Jan Jansen <[email protected]>
farodin91
force-pushed
the
add-watch-for-secrets
branch
from
e057153 to
cc20004
Compare
Contributor
Author
|
@agarcia-oss Would you like to review? |
Contributor
Author
|
@alvneiayu Would you like to review? |
Collaborator
|
well, I have a question about it. Could you provide me more information about your scenario. In the past, include a new watcher increases the CPU and memory of the product and it is important to know it and why we want to include it. Which tool are you using and the complete scenario, please? |
Contributor
Author
|
We create certificates externally for multiple cluster and rotate them periodically. We had issues the new certificates weren't loaded. |
alvneiayu
approved these changes
Jun 12, 2025
Collaborator
alvneiayu
left a comment
alvneiayu
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for your contribution @farodin91
agarcia-oss
pushed a commit
that referenced
this pull request
Aug 14, 2025
<!-- Before you open the request please review the following guidelines and tips to help it be more easily integrated: - Describe the scope of your change - i.e. what the change does. - Describe any known limitations with your change. - Please run any tests or examples that can exercise your modified code. Thank you for contributing! We will try to test and integrate the change as soon as we can, but be aware we have many GitHub repositories to manage and can't immediately respond to every request. There is no need to bump or check in on a pull request (it will clutter the discussion of the request). Also don't be worried if the request is closed or not integrated sometimes the priorities of Bitnami might not match the priorities of the pull request. Don't fret, the open source community thrives on forks and GitHub makes it easy to keep your changes in a forked repo. --> **Description of the change** <!-- Describe the scope of your change - i.e. what the change does. --> MR [#1737](#1737) added support for `--watch-for-secrets` but did not add it to the helm chart. **Benefits** <!-- What benefits will be realized by the code change? --> Will be able to enable --watch-for-secrets with helm without using args. **Possible drawbacks** <!-- Describe any known limitations with your change --> --watch-for-secrets is still beta. **Additional information** <!-- If there's anything else that's important and relevant to your pull request, mention that information here.--> Signed-off-by: John Allberg <[email protected]>
innocent541
added a commit
to innocent541/sealed-secrets
that referenced
this pull request
Oct 10, 2025
<!-- Before you open the request please review the following guidelines and tips to help it be more easily integrated: - Describe the scope of your change - i.e. what the change does. - Describe any known limitations with your change. - Please run any tests or examples that can exercise your modified code. Thank you for contributing! We will try to test and integrate the change as soon as we can, but be aware we have many GitHub repositories to manage and can't immediately respond to every request. There is no need to bump or check in on a pull request (it will clutter the discussion of the request). Also don't be worried if the request is closed or not integrated sometimes the priorities of Bitnami might not match the priorities of the pull request. Don't fret, the open source community thrives on forks and GitHub makes it easy to keep your changes in a forked repo. --> **Description of the change** <!-- Describe the scope of your change - i.e. what the change does. --> MR [#1737](bitnami-labs/sealed-secrets#1737) added support for `--watch-for-secrets` but did not add it to the helm chart. **Benefits** <!-- What benefits will be realized by the code change? --> Will be able to enable --watch-for-secrets with helm without using args. **Possible drawbacks** <!-- Describe any known limitations with your change --> --watch-for-secrets is still beta. **Additional information** <!-- If there's anything else that's important and relevant to your pull request, mention that information here.--> Signed-off-by: John Allberg <[email protected]>
IsaacCuevaswise59316
added a commit
to IsaacCuevaswise59316/sealed-secrets
that referenced
this pull request
Oct 12, 2025
<!-- Before you open the request please review the following guidelines and tips to help it be more easily integrated: - Describe the scope of your change - i.e. what the change does. - Describe any known limitations with your change. - Please run any tests or examples that can exercise your modified code. Thank you for contributing! We will try to test and integrate the change as soon as we can, but be aware we have many GitHub repositories to manage and can't immediately respond to every request. There is no need to bump or check in on a pull request (it will clutter the discussion of the request). Also don't be worried if the request is closed or not integrated sometimes the priorities of Bitnami might not match the priorities of the pull request. Don't fret, the open source community thrives on forks and GitHub makes it easy to keep your changes in a forked repo. --> **Description of the change** <!-- Describe the scope of your change - i.e. what the change does. --> MR [#1737](bitnami-labs/sealed-secrets#1737) added support for `--watch-for-secrets` but did not add it to the helm chart. **Benefits** <!-- What benefits will be realized by the code change? --> Will be able to enable --watch-for-secrets with helm without using args. **Possible drawbacks** <!-- Describe any known limitations with your change --> --watch-for-secrets is still beta. **Additional information** <!-- If there's anything else that's important and relevant to your pull request, mention that information here.--> Signed-off-by: John Allberg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Watch for new key secrets.
Benefits
We manage our secrets external their we have to restart sealed secrets always a new cert is created.
Possible drawbacks
Applicable issues
Additional information