Fixed all instances of calls silently dropping params #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcion to order params
lib/bitfinex/orders.rb
Outdated
| check_params(params, %i{is_hidden is_postonly ocoorder buy_price_oco}) | ||
|
|
||
| # for 'market' order, we need to pass a random positive price, not nil | ||
| price ||= rand(100) if type == "market" || type == "exchange market" |
Contributor
There was a problem hiding this comment.
You may just force price = 0.00001 for market orders
Contributor
Author
There was a problem hiding this comment.
Yeah, it actually makes sense. I was following the API doc too literally. ;)
Contributor
|
@arvicco thanks for all the great code you're pushing |
Contributor
|
Looks good |
prdn
added a commit
that referenced
this pull request
Mar 17, 2016
Fixed all instances of calls silently dropping params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, added type coercion to order params