feat: implement Hash and HashSums to performing hashing based on user provided hashers
#215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
bitfield
requested changes
Sep 30, 2024
Owner
bitfield
left a comment
bitfield
left a comment
There was a problem hiding this comment.
Great! Just a couple of tweaks needed.
script.go
Outdated
|
|
||
| // SHA256Sum returns the hex-encoded SHA-256 hash of the entire contents of the | ||
| // pipe, or an error. | ||
| // Deprecated: SHA256Sum has been deprecated by [Pipe.Hash]. To get the SHA 256 |
Owner
There was a problem hiding this comment.
Suggested change
| // Deprecated: SHA256Sum has been deprecated by [Pipe.Hash]. To get the SHA 256 | |
| // Deprecated: SHA256Sum has been deprecated by [Pipe.Hash]. To get the SHA-256 |
script.go
Outdated
| // SHA256Sums reads paths from the pipe, one per line, and produces the | ||
| // hex-encoded SHA-256 hash of each corresponding file, one per line. Any files | ||
| // that cannot be opened or read will be ignored. | ||
| // Deprecated: SHA256Sums has been deprecated by [Pipe.HashSums]. To get the SHA 256 |
Owner
There was a problem hiding this comment.
Suggested change
| // Deprecated: SHA256Sums has been deprecated by [Pipe.HashSums]. To get the SHA 256 | |
| // Deprecated: SHA256Sums has been deprecated by [Pipe.HashSums]. To get the SHA-256 |
script.go
Outdated
| // hex-encoded SHA-256 hash of each corresponding file, one per line. Any files | ||
| // that cannot be opened or read will be ignored. | ||
| // Deprecated: SHA256Sums has been deprecated by [Pipe.HashSums]. To get the SHA 256 | ||
| // encoding for the paths in the pipe, call `HashSums(sha256.new())` |
Owner
There was a problem hiding this comment.
Suggested change
| // encoding for the paths in the pipe, call `HashSums(sha256.new())` | |
| // hash for each file path in the pipe, call `HashSums(sha256.new())` |
bitfield
reviewed
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashsink that returns the hex encoded hash of the pipe contents based on thehash.Hashargument passed into the methodHashSumsfilter that produces the hex encoded hash of the files in the pathThis PR resolves #113, #130.