Small example tweaks #569
Merged
Small example tweaks #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename to use snake case - Land drone before sending sotp setpoint to prevent crash (detection)
- Aligns with PEP 8 module naming conventions - Improves consistency across examples directory
…t crash (detection)
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes example filenames to snake_case and makes safety improvements to drone examples. The changes align with PEP 8 naming conventions and prevent potential crashes by adjusting landing setpoints and forcing Lighthouse deck into V2 mode.
- Standardizes filename references from kebab-case to snake_case across examples and documentation
- Lowers landing setpoints in autonomy examples to prevent crash detection
- Forces Lighthouse deck into V2 mode for multi base station geometry estimation
Reviewed Changes
Copilot reviewed 6 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/lighthouse/multi_bs_geometry_estimation.py | Adds documentation and automatic Lighthouse V2 mode configuration |
| examples/cfbridge.py | Updates filename reference to snake_case |
| examples/autonomy/full_state_setpoint_demo.py | Lowers landing setpoint from 0.2m to 0.1m |
| examples/autonomy/autonomous_sequence.py | Adds final ground-level setpoint |
| docs/development/wireshark.md | Updates filename references to snake_case |
| docs/development/eeprom.md | Updates filename reference to snake_case |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gemenerik
dismissed stale reviews from ataffanel and ArisMorgens
via
06e23c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize example filenames to snake_case
Added / lowered "landing" setpoints to prevent crash (detection)
Force Lighthouse deck into V2 mode for multi BS geometry estimation example