Skip to content

Conversation

@Gadgeteering
Copy link
Contributor

Add crazy radio serial number reader to log

Add serial reader to the log and remove N/A
@gemenerik
Copy link
Member

Thanks for your PR. Can you run pre-commit on it?

@Gadgeteering
Copy link
Contributor Author

Pre commit checks

autopep8 wrapper.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check docstring is first.................................................Passed
Check JSON...............................................................Passed
Check for merge conflicts................................................Passed
Check Xml............................................(no files to check)Skipped
Check Yaml...............................................................Passed
Debug Statements (Python)................................................Passed
Detect Private Key.......................................................Passed
Fix double quoted strings................................................Passed
Fix End of Files.........................................................Passed
Flake8...................................................................Passed
Fix requirements.txt.................................(no files to check)Skipped
Reorder python imports...................................................Passed

@gemenerik
Copy link
Member

Sorry, to clarify. Can you run pre-commit, and then commit and push the changes. There is a pep8 formatting issue with the current PR.

@Gadgeteering
Copy link
Contributor Author

Sorry my mistake ran pre-commit and pushed

@gemenerik gemenerik merged commit 57c4b18 into bitcraze:master Dec 9, 2024
@gemenerik
Copy link
Member

Again thanks so much for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants