Skip to content

Conversation

@ToveRumar
Copy link
Contributor

The datetime object does not hold total seconds since Epoch time.The seconds variable is only seconds since last full minute. We need a deltatime since Epoch start to get total seconds since then

@ToveRumar
Copy link
Contributor Author

Fixes the issue from this discussion;
https://github.com/orgs/bitcraze/discussions/1278

@ToveRumar ToveRumar force-pushed the toverumar/fix_wireshark_time branch 2 times, most recently from 29df085 to 599be51 Compare May 7, 2024 11:46
@gemenerik
Copy link
Member

Wireshark wiki confirms it should be seconds since Unix time. You could consider using time.time() since that returns Unix time in seconds.

@ToveRumar ToveRumar force-pushed the toverumar/fix_wireshark_time branch from 599be51 to 1a2d3cb Compare May 7, 2024 13:05
The datetime object does not hold total seconds since Epoch time.The seconds variable is only seconds since last full minute. We need
a deltatime since Epoch start to get total seconds since then
@ToveRumar ToveRumar force-pushed the toverumar/fix_wireshark_time branch from 1a2d3cb to b875fca Compare May 7, 2024 13:11
@ToveRumar
Copy link
Contributor Author

Wireshark wiki confirms it should be seconds since Unix time. You could consider using time.time() since that returns Unix time in seconds.

I liked that solution better. See update

@gemenerik gemenerik self-requested a review May 7, 2024 13:28
Copy link
Member

@gemenerik gemenerik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ToveRumar ToveRumar merged commit c7eaabe into master May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants