Improve wall following #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichardsson
approved these changes
May 3, 2023
Contributor
krichardsson
left a comment
krichardsson
left a comment
There was a problem hiding this comment.
Much nicer and easier to read!
I found a few magic numbers (comments in the code) if you want to fix them, but nothing big.
Good job!
Contributor
Author
|
Thanks for reviewing! And good you found those extra magic numbers... wonder if there is some kind of CI check for this we could implement. I've made some changes per your suggestion and will merge it now. |
This was referenced May 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this PR ive introduced the wall following demo: #390
There were comments made by @krichardsson there that I've addressed + more documentation and clarification