Fix documentaion and some code typos #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi! Sorry for the late reply, but indeed this is very helpful. I had a quick check and it all seems fine to me. Probably the define RETRYCOUNT_BEFORE_DISCONNECT should be removed completely, but ill make a seperate push for that. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos in project documentation, docstrings, and some code segments. There are still a few remaining misspelled methods and argument names; however, changing them may break backwards compatibility for some dependents, but they're readability is not largely impacted.
While the scope of this PR is quite large, the impact to anything other than readability should be nonexistent so I have not created an associated issue.