Increase write flash request timeout to 2.5s, fixes #98 #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #98, this PR raises the timeout for "write flash" requests to 2.5 seconds unconditionally to cater for the increased time needed to erase a page of 128K on an STM32F405.
Note that the timeout is applied unconditionally, even if we are flashing to the nRF51. In my opinion this is not a big deal because the flash packets go through just fine almost all the time, so there is almost never any need for re-sending them. However, re-sending them too early when the packet in fact went through can break the flashing process, as indicated by #98.