Skip to content

Conversation

@ntamas
Copy link
Contributor

@ntamas ntamas commented Dec 17, 2019

As discussed in #98, this PR raises the timeout for "write flash" requests to 2.5 seconds unconditionally to cater for the increased time needed to erase a page of 128K on an STM32F405.

Note that the timeout is applied unconditionally, even if we are flashing to the nRF51. In my opinion this is not a big deal because the flash packets go through just fine almost all the time, so there is almost never any need for re-sending them. However, re-sending them too early when the packet in fact went through can break the flashing process, as indicated by #98.

@ataffanel ataffanel merged commit 5bd21fc into bitcraze:master Dec 18, 2019
@ataffanel
Copy link
Member

Thanks a lot, this is going to help a lot of people and save a lot of time!
I merged the PR, lets keep the issue open a little while to make sure the problem is indeed gone.

@ntamas
Copy link
Contributor Author

ntamas commented Dec 18, 2019

I'm fine with keeping the issue open but you just closed it ;)

@ataffanel
Copy link
Member

Thanks for the heads-up, it was automatically closed by github because of this PR title :-).

@ntamas ntamas deleted the bugfix/fix-incorrect-flashing-on-stm32 branch December 27, 2019 10:41
@krichardsson krichardsson added this to the 0.1.9 milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants