Append the device only if the manufacturer name is 'Bitcraze AB' #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When devices with the same VendorID and ProductID as the roadrunner/bitcraze is connected, the cflib fails to connect to the device. A quick fix for this is done by checking if the manufacturer name is 'Bitcraze AB'
Member
|
Thanks for the fix! I am merging it. |
Contributor
Author
|
Heads up guys, if the manufacturer name is changed in the future, this fix wouldn't work. In fact, it will not even connect to any devices. I think we should think about a robust way to find the devices. |
Member
|
Yes agreed, the real solution would be to have out own VID/PID but getting a VID is currently not possible. Maybe ST can help with that .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When devices with the same VendorID and ProductID as the
roadrunner/crazyflie are connected at the same time, the cflib fails to connect to
the device. A quick fix for this is done by checking if the
manufacturer name is 'Bitcraze AB'