Backport: Add apply_unconfirmed_txs_events and apply_evicted_txs_events#399
Open
notmandatory wants to merge 4 commits intobitcoindevkit:release/2.xfrom
Open
Backport: Add apply_unconfirmed_txs_events and apply_evicted_txs_events#399notmandatory wants to merge 4 commits intobitcoindevkit:release/2.xfrom
notmandatory wants to merge 4 commits intobitcoindevkit:release/2.xfrom
Conversation
…events - refactor _events functions to use new map_transactions helper
This can be used to generate `WalletEvent`s after executing a function defined by the caller. Refactored the `*_events` functions to use the events helper internally. test: Test that no events are returned by applying an empty Update and applying the same Update twice.
notmandatory
force-pushed
the
backport/mempool_events
branch
from
df35816 to
602ab20
Compare
Member
Author
|
Set to draft until I can figure out the MSRV issues. |
notmandatory
force-pushed
the
backport/mempool_events
branch
8 times, most recently
from
5b49cef to
2c6b2ad
Compare
notmandatory
force-pushed
the
backport/mempool_events
branch
from
2c6b2ad to
ff7c15d
Compare
Member
Author
|
Finally got it to build successfully with msrv 1.63. I need to do a little more research to figure out why I had to pin so many dependencies. |
Member
Author
|
From chat on discord sounds like I'm not the only one who's had issues with these crates not respecting MSRV so moved this to ready to review. https://discord.com/channels/753336465005608961/1368973459551555605/1480933702778491061 |
ValuedMammal
approved these changes
Mar 11, 2026
Collaborator
ValuedMammal
left a comment
ValuedMammal
left a comment
There was a problem hiding this comment.
ACK ff7c15d; ran the tests locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #388 to
release/2.xbranch.Notes to the reviewers
I had to make some small changes in 5740150 to fix differences in 2.x use statements related to
fmtand thatWalletEventsisn't exposed at the module level.Changelog notice
Checklists
All Submissions:
just pbefore pushingNew Features: