Conversation
Run `cargo update` and bump depends in Cargo.toml. Normal: bdk_chain 0.23.1 -> 0.23.2 bitcoin 0.32.7 -> 0.32.8 miniscript 12.3.1 -> 12.3.5 rand_core 0.6.0 -> 0.6.4 anyhow 1.0.98 -> ^1 bip39 2.0 -> 2.2.2 tempfile 3.20.0 -> 3.26.0 Dev: bdk_electrum 0.23.1 -> 0.23.2 clap 4.5.17 -> 4.5.60 ctrlc 3.4.6 -> 3.5.2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 79.77% 79.77%
=======================================
Files 24 24
Lines 5266 5266
Branches 241 241
=======================================
Hits 4201 4201
Misses 988 988
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Since wallet is the only crate in this lib it would make sense to return to the |
|
Should #390 be included in this release? |
Yes, sounds good!
I didn't get a change to review and test it yet, though it's also non-breaking and can land in the next minor release. |
oleonardolima
left a comment
There was a problem hiding this comment.
I left a few comments with fixes we should have before merge/release.
551a277 to
92e683b
Compare
|
Description
Notes to the reviewers
The CHANGELOG refers to
v3.0.0, but the link to thev3.0.0tag won't be live until the 3.0 is finally released. This release will be taggedv3.0.0-rc.1.close #395
Checklists
All Submissions: