Deprecate list_unspent which has an unnecessary .collect()#766
Closed
evanlinjin wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Deprecate list_unspent which has an unnecessary .collect()#766evanlinjin wants to merge 1 commit intobitcoindevkit:masterfrom
list_unspent which has an unnecessary .collect()#766evanlinjin wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Use `iter_unspent` instead, as it returns an iterator directly.
evanlinjin
force-pushed
the
deprecate_list_unspent
branch
from
bbe8087 to
a75b17d
Compare
Member
|
Concept ACK! I just wonder, will this method change again after the bdk-core integration, or do you think it can remain the same? I'd avoid breaking this API in 0.24, and then immediately deprecate |
Member
Author
Good point. Let's discuss later today. |
Contributor
|
Concept ACK.. |
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce
Wallet::iter_unspent, which replacesWallet::list_unspent. Thus avoiding an unnecessary.collect()for most use cases.Changelog notice
Introduce
Wallet::iter_unspent, which replacesWallet::list_unspent. Thus avoiding an unnecessary.collect()for most use cases.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
* [ ] I've added tests for the new feature