Fix the release process#754
Conversation
|
|
||
| - [ ] Double check that your local `master` is up-to-date with the upstream repo. | ||
| - [ ] Create a new branch called `release/MAJOR.MINOR+1` from `master`. | ||
| - [ ] Bump the `release/MAJOR.MINOR+1` branch to `MAJOR.MINOR+1.0-rc.1` version. |
There was a problem hiding this comment.
Was wondering if there's a particular reason to also update the cargo version to include the -rc.x part of the version. Is it just to be more explicit so pre-release users know it's not official yet?
It's not a big deal for me either way, but the reason I left it off was that I figured anyone doing rc testing would be pointing to the release branch or rc tag in a [patch.crates-io] statement. And then could just remove that patch line once the release was out, also was trying to avoid extra Cargo.toml file editing steps.
There was a problem hiding this comment.
It's just to make sure the version is reflected into cargo, otherwise from cargo's perspective all of those are the same version, it's just different tags pointing to them.
So for example when I run a cargo build I see "bdk 0.22-rc.1" instead of just "bdk 0.22" which may be confusing.
2 participants
Description
A few things I noticed while doing the 0.22 release.
Follow-up of #544
Checklists
All Submissions: