Rename set_current_height to current_height#667
Merged
afilini merged 1 commit intobitcoindevkit:release/0.20.0from Jul 13, 2022
Merged
Rename set_current_height to current_height#667afilini merged 1 commit intobitcoindevkit:release/0.20.0from
set_current_height to current_height#667afilini merged 1 commit intobitcoindevkit:release/0.20.0from
Conversation
Usually we don't have any prefix except for methods that can *add* to a list or replace the list entirely (e.g. `add_recipients` vs `set_recipients`)
danielabrozzoni
approved these changes
Jul 13, 2022
Member
danielabrozzoni
left a comment
danielabrozzoni
left a comment
There was a problem hiding this comment.
utACK 92b9597 - I'm sorry I didn't notice it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Usually we don't have any prefix except for methods that can add to a list or replace the list entirely (e.g.
add_recipientsvsset_recipients)I missed this during review of #611
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing