Skip to content

[ci] Manually set rust stable version in CI pipeline#290

Merged
afilini merged 1 commit intobitcoindevkit:masterfrom
notmandatory:ci/fix_stable
Feb 16, 2021
Merged

[ci] Manually set rust stable version in CI pipeline#290
afilini merged 1 commit intobitcoindevkit:masterfrom
notmandatory:ci/fix_stable

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Feb 15, 2021

Description

This PR sets the rust stable version in the CI pipeline to 1.50.0. This value will need to be updated manually when a new stable version of Rust 🦀 is released. Any clippy or other fixes required by a new stable version should be fixed in the same PR.

Resolves discussion in #282

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory marked this pull request as draft February 15, 2021 22:28
@notmandatory notmandatory changed the title [ci] Define specific stable_rust_version in CI pipeline [ci] Manually set rust stable version in CI pipeline Feb 15, 2021
@notmandatory notmandatory marked this pull request as ready for review February 15, 2021 22:53
@afilini afilini merged commit fa5a5c8 into bitcoindevkit:master Feb 16, 2021
@RCasatta
Copy link
Member

Sorry for commenting late, maybe it was been better to use:

env:
  RUST_STABLE: 1.50.0

and then ${{ env.RUST_STABLE }} when needed

@notmandatory
Copy link
Member Author

I did try using a global 'env' but it isn't supported across jobs since they run in different containers. So I just hard coded it for now. Maybe it will be possible in the future.

@notmandatory notmandatory deleted the ci/fix_stable branch September 16, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants