Conversation
and set edition = "2018" which I guess you are meant to do.
|
I prefer the out of the box imports style since it's what most other projects use, unless there's a compelling reason to change it. That said, the merged imports are easy enough to read and |
|
Personally, I slightly prefer without nested imports |
|
I prefer non-merged imports. There are trade offs, the main ones being IMO pro of merge imports:
cons of merged imports
Personally I think the merge conflict thing is the biggest consideration hence my preference for non-merged imports. Sorry @LLFourn if my comment on the PR that you link to was misleading, I already had an opinion but did not air it then. |
|
I can't really describe why (maybe it's just that I'm more used to them), but I also like the current non-merged style better.. |
|
Thanks all. |
Was brought up here: #279 (comment)
So I made PR to see what it would look like and to see if we have overwhelming support for it. I think I prefer merge imports as it's easier to see what top level modules are being imported. It does add some more LoC funnily enough.
Voice your opinion. There are also other options we could turn on in rustfmt. See here which could be added to the PR.