Skip to content

fix(ci): pin toolchain, and switch to actions-rust-lang/setup-rust-toolchain#2151

Merged
oleonardolima merged 1 commit intobitcoindevkit:release/chain-0.23.xfrom
oleonardolima:fix/ci-code-coverage-step
Mar 11, 2026
Merged

fix(ci): pin toolchain, and switch to actions-rust-lang/setup-rust-toolchain#2151
oleonardolima merged 1 commit intobitcoindevkit:release/chain-0.23.xfrom
oleonardolima:fix/ci-code-coverage-step

Conversation

@oleonardolima
Copy link
Collaborator

Description

Currently the code coverage step is failing on release/chain-0.23.x, this PR applies the fix that's currently in master.

Changelog notice

### Changed

- ci(coverage): switch to `action-rust-lang/setup-rust-toolchain`.
- ci(coverage): pin toolchain to `nightly-2025-11-27`.

Checklists

All Submissions:

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@oleonardolima oleonardolima added this to the Chain 0.23.3 milestone Mar 11, 2026
@oleonardolima oleonardolima self-assigned this Mar 11, 2026
@oleonardolima oleonardolima added chore Non-coding related work backport A bug fix or security patch to be ported to a previous release labels Mar 11, 2026
@luisschwab
Copy link
Member

@oleonardolima you need to pin it to a hash

@oleonardolima
Copy link
Collaborator Author

@oleonardolima you need to pin it to a hash

No, I updated it to match master and allow the ref-pin.

`actions-rust-lang/setup-rust-toolchain`

- switch to `action-rust-lang/setup-rust-toolchain`.
- pin toolchain to `nightly-2025-11-27`, this fixes a CI failure resulting
  from use of rustc nightly with `llvm-cov`.
- adds `zizmor.yml` config file, allow
  `actions-rust-lang/setup-rust-toolchain` ref-pin.
@oleonardolima oleonardolima force-pushed the fix/ci-code-coverage-step branch from 4e8d576 to c99a547 Compare March 11, 2026 20:06
@oleonardolima oleonardolima marked this pull request as ready for review March 11, 2026 20:12
Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c99a547

@luisschwab luisschwab requested a review from notmandatory March 11, 2026 20:17
@oleonardolima oleonardolima merged commit ecfe271 into bitcoindevkit:release/chain-0.23.x Mar 11, 2026
19 checks passed
@oleonardolima oleonardolima deleted the fix/ci-code-coverage-step branch March 11, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport A bug fix or security patch to be ported to a previous release chore Non-coding related work

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants