fix(chain): forward confirmation_height_upper_bound in Anchor implementation for &A#2120
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Mar 6, 2026
Conversation
34 tasks
ValuedMammal
approved these changes
Feb 25, 2026
Dmenec
suggested changes
Feb 26, 2026
|
approach ACK, how the comment above says
only change need is to fix the clippy, all another test is ok |
…l for `&A` The blanket `Anchor` impl for `&A` was missing the `confirmation_height_upper_bound` method, causing it to fall back to the default implementation instead of delegating to the inner type.
evanlinjin
force-pushed
the
fix/forward-confirmation-height-upper-bound-anchor
branch
from
eba8df9 to
5d97e13
Compare
Dmenec
approved these changes
Mar 6, 2026
Collaborator
|
ACK 5d97e13 |
1 task
evanlinjin
added a commit
that referenced
this pull request
Mar 12, 2026
…` in `Anchor` implementation for `&A` 00d7f62 fix(chain): forward `confirmation_height_upper_bound` in `Anchor` impl for `&A` (志宇) Pull request description: ### Description Backport of #2120 Depends on #2148 The blanket `Anchor` impl for `&A` was missing the `confirmation_height_upper_bound` method, causing it to fall back to the default implementation instead of delegating to the inner type. ### Changelog notice ```md Fixed: - The `Anchor::confirmation_height_upper_bound` impl was missing for `&A`, causing it to fallback to the default impl. ``` ### Checklists #### All Submissions: * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) ACKs for top commit: luisschwab: ACK 00d7f62 notmandatory: ACK 00d7f62 Tree-SHA512: 919ecc07e82e4c902ba30b576a4617ff63afc17eb4176410dac9abdbec5425a0ba7139312768365386c1d59bd7eb6b733bbae45c8a25d628996135dd226f715f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The blanket
Anchorimpl for&Awas missing theconfirmation_height_upper_boundmethod, causing it to fall back to the default implementation instead of delegating to the inner type.Changelog notice
Checklists
All Submissions:
Bugfixes:
* [ ] This pull request breaks the existing API* [ ] I've added tests to reproduce the issue which are now passing* [ ] I'm linking the issue being fixed by this PR