fix(ci): pin bzip2-sys to 0.1.12#1867
Merged
evanlinjin merged 2 commits intobitcoindevkit:masterfrom Mar 5, 2025
Merged
Conversation
3 tasks
Collaborator
Author
|
I don't know why code coverage is failing though, taking a look. |
ValuedMammal
force-pushed
the
ci/pin-bzip2-sys-to-0.1.12
branch
from
0cd61be to
cd7e358
Compare
ValuedMammal
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It looks like CI is failing due to the latest release of https://github.com/trifectatechfoundation/bzip2-rs/releases/tag/v0.5.2 which is a dependency of zip and therefore from electrsd.
It's failing on MSRV 1.63.0 step raising the following error:
error[E0658]: use of unstable library feature 'core_ffi_c'.This PR adds bzip2-sys to the pinned dependency list, pinning it to
0.1.12.Notes to the reviewers
Changelog notice
bzip2-systo the pinned dependency list, pinning it to0.1.12.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing