Skip to content

docs: fix dead links in README.md#1856

Closed
rebustron wants to merge 1 commit intobitcoindevkit:masterfrom
rebustron:master
Closed

docs: fix dead links in README.md#1856
rebustron wants to merge 1 commit intobitcoindevkit:masterfrom
rebustron:master

Conversation

@rebustron
Copy link

Description

Hi! I fixed outdated and incorrect paths in README.md, ensuring all internal links point to the correct locations.

Changes:

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rebustron

ACK a245814

Note also that it is preferable to conform to conventional commits style.

@ValuedMammal ValuedMammal added this to the 1.2.0 milestone Feb 25, 2025
@ValuedMammal ValuedMammal added the documentation Improvements or additions to documentation label Feb 25, 2025
Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a245814

@oleonardolima oleonardolima mentioned this pull request Mar 3, 2025
@ValuedMammal ValuedMammal removed this from the 1.2.0 milestone Mar 10, 2025
@luisschwab
Copy link
Member

This can be closed.

@notmandatory notmandatory moved this to Needs Review in BDK Wallet Mar 14, 2025
@notmandatory notmandatory added this to the 1.2.0 milestone Mar 14, 2025
@notmandatory
Copy link
Member

Oops this was fixed in #1882. Closing.

@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Mar 14, 2025
@notmandatory notmandatory removed this from the 1.2.0 milestone Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants