Derive Clone on AddressInfo#1560
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Aug 21, 2024
Merged
Conversation
evanlinjin
reviewed
Aug 16, 2024
Member
There was a problem hiding this comment.
ConceptACK
Just two things before I ACK:
Can you please change the commit message to be of the Conventional Commits format? I.e. feat(wallet): Derive Clone on AddressInfo.
Also, please include the Changelog notice section in the PR description. I.e.
### Changelog notice
* Added `Clone` impl for `AddessInfo`.Thanks in advance!
praveenperera
force-pushed
the
clone-on-address-info
branch
from
d7b1bfc to
b842927
Compare
Contributor
Author
|
@evanlinjin sorry about that, complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Derive
CloneonAddressInfoso I can clone itChecklists
All Submissions:
cargo fmtandcargo clippybefore committingChangelog notice
Cloneimpl forAddessInfo