Skip to content

fix(example_cli): add bitcoin and rand dependencies#1549

Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom
notmandatory:fix/chain_example_cli
Aug 14, 2024
Merged

fix(example_cli): add bitcoin and rand dependencies#1549
notmandatory merged 2 commits intobitcoindevkit:masterfrom
notmandatory:fix/chain_example_cli

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Aug 12, 2024

Description

Fix building example_cli by adding the bitcoin and rand dependencies so it, and the crates that depend on it, can be built independently and not only from the workspace.

Notes to the reviewers

I also added the build-examples CI job to verify we can build examples individually.

Changelog notice

None.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory self-assigned this Aug 12, 2024
@notmandatory notmandatory added documentation Improvements or additions to documentation ci labels Aug 12, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Aug 12, 2024
@notmandatory notmandatory force-pushed the fix/chain_example_cli branch 5 times, most recently from 245fe8a to 50d16bb Compare August 12, 2024 22:54
@notmandatory notmandatory force-pushed the fix/chain_example_cli branch from 50d16bb to f54d2fb Compare August 13, 2024 00:05
@ValuedMammal
Copy link
Collaborator

I'm not sure if it matters but we could possibly just add a bitcoin dependency to example_cli with the necessary features and not have to add new features to bdk_chain

@notmandatory notmandatory force-pushed the fix/chain_example_cli branch from f54d2fb to 9346900 Compare August 13, 2024 00:54
The bitcoin and rand dependencies are required to build examples
independently and not from the top level bdk workspace.
@notmandatory notmandatory force-pushed the fix/chain_example_cli branch from 9346900 to 3675a9e Compare August 13, 2024 00:56
@notmandatory notmandatory changed the title chain: add "base64" and "rand-std" features fix(example_cli): add bitcoin and rand dependencies Aug 13, 2024
@notmandatory
Copy link
Member Author

I'm not sure if it matters but we could possibly just add a bitcoin dependency to example_cli with the necessary features and not have to add new features to bdk_chain

Good idea, the bdk_wallet crate had it's own dependency on bitcoin and rand (for tests). I updated this PR to not add features to bdk_chain and instead add the missing local dependencies to example_cli.

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3675a9e

Copy link

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3675a9e

@notmandatory notmandatory merged commit e0822d7 into bitcoindevkit:master Aug 14, 2024
@notmandatory notmandatory deleted the fix/chain_example_cli branch May 26, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants