fix(example_cli): add bitcoin and rand dependencies#1549
Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom Aug 14, 2024
Merged
fix(example_cli): add bitcoin and rand dependencies#1549notmandatory merged 2 commits intobitcoindevkit:masterfrom
notmandatory merged 2 commits intobitcoindevkit:masterfrom
Conversation
245fe8a to
50d16bb
Compare
50d16bb to
f54d2fb
Compare
Collaborator
|
I'm not sure if it matters but we could possibly just add a bitcoin dependency to |
f54d2fb to
9346900
Compare
The bitcoin and rand dependencies are required to build examples independently and not from the top level bdk workspace.
9346900 to
3675a9e
Compare
Member
Author
Good idea, the |
Merged
5 tasks
storopoli
approved these changes
Aug 13, 2024
This was referenced Aug 22, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix building
example_cliby adding the bitcoin and rand dependencies so it, and the crates that depend on it, can be built independently and not only from the workspace.Notes to the reviewers
I also added the build-examples CI job to verify we can build examples individually.
Changelog notice
None.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: