test(electrum): Test sync in reorg and no-reorg situations#1535
Merged
evanlinjin merged 2 commits intobitcoindevkit:masterfrom Aug 12, 2024
Merged
test(electrum): Test sync in reorg and no-reorg situations#1535evanlinjin merged 2 commits intobitcoindevkit:masterfrom
evanlinjin merged 2 commits intobitcoindevkit:masterfrom
Conversation
LagginTimes
force-pushed
the
electrum_sync_test
branch
2 times, most recently
from
a15f6f3 to
01f5a0f
Compare
evanlinjin
requested changes
Aug 5, 2024
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
Good work with this. Moving forward, I recommend improving the docs and adding more clarity to the testing logic. I also included a bunch of nits for you to consider including.
LagginTimes
force-pushed
the
electrum_sync_test
branch
4 times, most recently
from
a47b802 to
c080123
Compare
Member
|
The commit also adds a method to the |
evanlinjin
requested changes
Aug 8, 2024
LagginTimes
force-pushed
the
electrum_sync_test
branch
4 times, most recently
from
f274e4c to
ff3f5da
Compare
evanlinjin
reviewed
Aug 9, 2024
LagginTimes
force-pushed
the
electrum_sync_test
branch
from
ff3f5da to
13ebe13
Compare
evanlinjin
reviewed
Aug 9, 2024
LagginTimes
force-pushed
the
electrum_sync_test
branch
2 times, most recently
from
360a78c to
73e34ec
Compare
Add test for `bdk_electrum` to make sure previously unconfirmed transactions get confirmed again in both reorg and no-reorg situations.
LagginTimes
force-pushed
the
electrum_sync_test
branch
from
73e34ec to
df80a0f
Compare
evanlinjin
requested changes
Aug 12, 2024
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
LGTM. Once these are addressed and changelog is added to PR description, I am happy to merge.
Added `wait_until_electrum_sees_txid` method to `TestEnv`. Both `bdk_electrum` wait methods now have a `timeout` option. Removed the exponential polling delay in lieu of a fixed delay inside the `bdk_electrum` wait methods.
LagginTimes
force-pushed
the
electrum_sync_test
branch
from
df80a0f to
2c0bc45
Compare
| assert_eq!( | ||
| get_balance(&recv_chain, &recv_graph)?, | ||
| Balance { | ||
| trusted_pending: SEND_AMOUNT * depth as u64, |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1125.
Description
Add new test for
bdk_electrumto make sure previously unconfirmed transactions get confirmed again in both reorg and no-reorg situations.Changelog notice
wait_until_electrum_sees_txidmethod toTestEnv.wait_until_electrum_sees_blocknow has aDurationinput for timeout.wait_until_electrum_sees_block.test_synctobdk_electrumto make sure previously unconfirmed transactions get confirmed in both reorg and no-org situations.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing