Skip to content

Inconsistent use of check_wallet_descriptor #1557

@ValuedMammal

Description

@ValuedMammal

After #1533 we fail to call check_wallet_descriptor in all arms of a match block during load, but this was correct in v1.0.0-beta.1. Also, we apparently never apply the check during new wallet creation.

// parameters must match
Some(make_desc) => {
let (exp_desc, keymap) =
make_desc(&secp, network).map_err(LoadError::Descriptor)?;
if desc.descriptor_id() != exp_desc.descriptor_id() {
return Err(LoadError::Mismatch(LoadMismatch::Descriptor {
keychain: KeychainKind::Internal,
loaded: Some(desc),
expected: Some(exp_desc),
}));
}

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions