Merged
Conversation
ulrichard
force-pushed
the
feature/update_bdk_v0.28
branch
2 times, most recently
from
932dba8 to
a1e156a
Compare
ulrichard
commented
Apr 25, 2023
| rust: | ||
| - 1.65.0 # STABLE | ||
| - 1.57.0 # MSRV | ||
| - 1.59.0 # MSRV |
Collaborator
Author
There was a problem hiding this comment.
Following the MSRV of a sub-dependency:
zip-rs/zip-old@a06b947
Member
There was a problem hiding this comment.
We should be able to keep the 1.57.0 MSRV by adding to Cargo.toml:
[dev-dependencies]
# zip versions after 0.6.3 don't work with our MSRV 1.57.0
zip = "=0.6.3"
# base64ct versions at 1.6.0 and higher have MSRV 1.60.0
base64ct = "<1.6.0"See also: bitcoindevkit/bdk#877
21 tasks
ulrichard
force-pushed
the
feature/update_bdk_v0.28
branch
from
a1e156a to
bea8c17
Compare
19 tasks
19 tasks
ulrichard
force-pushed
the
feature/update_bdk_v0.28
branch
2 times, most recently
from
10d6118 to
98a09a6
Compare
Not updating electrsd because of the MSRV
ulrichard
force-pushed
the
feature/update_bdk_v0.28
branch
from
98a09a6 to
02bba37
Compare
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.