Skip to content

Represent '-1' indices as empty strings in StringArrayEncoding#833

Merged
padix-key merged 9 commits intobiotite-dev:mainfrom
padix-key:issue-831
Oct 8, 2025
Merged

Represent '-1' indices as empty strings in StringArrayEncoding#833
padix-key merged 9 commits intobiotite-dev:mainfrom
padix-key:issue-831

Conversation

@padix-key
Copy link
Copy Markdown
Member

@padix-key padix-key commented Oct 4, 2025

Fixes #831

Furthermore in BinaryCIF files

  • the compression of short float arrays via compress() is improved,
  • Decoded arrays from data encoded with only ByteEncoding is fixed.

To makes the CI pass, this PR also fixes a regex issue in afdb.fetch().

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 4, 2025

CodSpeed Performance Report

Merging #833 will not alter performance

Comparing padix-key:issue-831 (fce71c6) with main (f8b40d2)

Summary

✅ 59 untouched

@padix-key padix-key changed the title Represent empty strings as '-1' indices in StringArrayEncoding Represent '-1' indices as empty strings in StringArrayEncoding Oct 8, 2025
@padix-key padix-key merged commit dee7153 into biotite-dev:main Oct 8, 2025
24 checks passed
@padix-key padix-key deleted the issue-831 branch October 14, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem while parsing bcif files written by py-mmcif

1 participant