fix: allow matching nan values in annotations (e.g. when b_factors are set to nan)#714
Merged
padix-key merged 4 commits intobiotite-dev:mainfrom Dec 12, 2024
Conversation
CodSpeed Performance ReportMerging #714 will not alter performanceComparing Summary
|
padix-key
requested changes
Dec 10, 2024
Member
padix-key
left a comment
There was a problem hiding this comment.
Hi, thanks for bringing this up. In my opinion you are right: When two AtomArrayhave NaN annotations at the same position, as a user I would expect that they are still the same. I would even suggest to be more strict and enforce this behavior (and remove the parameter), but I do not have a strong opinion here.
I only left a small nit, otherwise this looks good to me.
Contributor
Author
|
Thank you for the quick review @padix-key , I've updated the docstring as you suggested & fixed ruff. Good to merge from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tiny fix, to allow counting
nanvalues as equal in annotations. This makes sense in cases where annotations are flagged as not available (e.g. b_factor =nan).