-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[MNT] WidgetTest: Add tests on nasty data #6223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janezd
wants to merge
14
commits into
biolab:master
Choose a base branch
from
janezd:basic-test-on-nasty-data
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c43492 to
324c7d5
Compare
324c7d5 to
e0205d5
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (93.93%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6223 +/- ##
==========================================
+ Coverage 88.91% 89.02% +0.10%
==========================================
Files 335 335
Lines 73978 74086 +108
==========================================
+ Hits 65779 65953 +174
+ Misses 8199 8133 -66 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Widget are supposed to survive data all-nans or without rows, attributes, classes... Many don't because we don't test it.
Also fixes #7151 (via https://github.com/biolab/orange3/pull/6223/files#diff-55f7ddbd86ca693bb61aeac9378a53ae12ba29aecf48fc73f7ebe012a36a7ebaR402).
Description of changes
WidgetTest, the base class for all widget tests now adds a test that sends nasty data to all inputs that acceptTable.PR adds various fixes to widgets so they pass the tests.
Includes