Skip to content

Conversation

@janezd
Copy link
Contributor

@janezd janezd commented Nov 25, 2022

Issue

Widget are supposed to survive data all-nans or without rows, attributes, classes... Many don't because we don't test it.

Also fixes #7151 (via https://github.com/biolab/orange3/pull/6223/files#diff-55f7ddbd86ca693bb61aeac9378a53ae12ba29aecf48fc73f7ebe012a36a7ebaR402).

Description of changes

WidgetTest, the base class for all widget tests now adds a test that sends nasty data to all inputs that accept Table.

PR adds various fixes to widgets so they pass the tests.

Includes
  • Code changes
  • Tests

@janezd janezd marked this pull request as draft December 22, 2023 08:10
@janezd janezd force-pushed the basic-test-on-nasty-data branch from 9c43492 to 324c7d5 Compare November 6, 2025 20:47
@janezd janezd force-pushed the basic-test-on-nasty-data branch from 324c7d5 to e0205d5 Compare November 17, 2025 21:32
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.02%. Comparing base (c807a41) to head (a15eac3).
⚠️ Report is 20 commits behind head on master.

❌ Your patch check has failed because the patch coverage (93.93%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6223      +/-   ##
==========================================
+ Coverage   88.91%   89.02%   +0.10%     
==========================================
  Files         335      335              
  Lines       73978    74086     +108     
==========================================
+ Hits        65779    65953     +174     
+ Misses       8199     8133      -66     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Louvain Clustering: persistent error message and confusing warning message

2 participants