This repository was archived by the owner on Aug 29, 2022. It is now read-only.
Weight Progress added implicitly during map #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwaldowski
force-pushed
the
zwaldowski/explicitly-implicit
branch
from
848ebb6 to
72764dc
Compare
zwaldowski
force-pushed
the
zwaldowski/explicitly-implicit
branch
from
72764dc to
96ed71e
Compare
zwaldowski
force-pushed
the
zwaldowski/explicitly-implicit
branch
from
96ed71e to
1d49f93
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Addresses #267. Inside the handler to
Task.map, you can createProgressobjects for implicit composition (i.e.,Progress(parent: .current())orProgress(totalUnitCount: foo)and they will be composed at a 100x slice just like explicitly creating one inTask.andThen.Testing
Addresses new code with a test case. The new 100% coverage from #265 remains.
API Changes
No public API change.