This repository was archived by the owner on Aug 29, 2022. It is now read-only.
Simplifies relationship between Either and Task #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwaldowski
force-pushed
the
zwaldowski/task-redesign-I
branch
from
aee2b53 to
b69c1c5
Compare
zwaldowski
force-pushed
the
zwaldowski/task-redesign-I
branch
3 times, most recently
from
a942738 to
e358275
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Removes requirements from
Eitherthat aren't describing the bits used to work on instances ofTaskResultthrough protocol extensions, and notes this intent in the documentation. This paves the way for more pieces of Task redesigns.Testing
100% coverage of
Either,TaskResult.API Changes
Yes, but should be source compatible. (Needs review of this.)