Use new Sender constructors and expose ability to Courier::Sender::set_parent_pointer #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_parent_pointer.
tanaya-mankad
approved these changes
Jan 9, 2026
Contributor
tanaya-mankad
left a comment
tanaya-mankad
left a comment
There was a problem hiding this comment.
I updated Courier again on top of your update-courier. This whole shebang is self-consistent.
nealkruis
commented
Jan 9, 2026
Comment on lines
-41
to
-46
| - os: ubuntu | ||
| os_ver: "20.04" | ||
| config: Debug | ||
| coverage: true | ||
| cc: gcc-10 | ||
| cxx: g++-10 |
Member
Author
There was a problem hiding this comment.
Why are we removing this?
Contributor
There was a problem hiding this comment.
Not supported: https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories
(The indication is that the job never starts.)
Member
Author
There was a problem hiding this comment.
Shouldn't we update instead so we still get the code coverage analysis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the PIMPL paradigm used in Btwxt, the public RegularGridInterpolator is not a Courier::Sender class. This uses a cleaner Sender class constructor, and exposes the
set_parent_pointermethod in the public class so messages can be passed up through calling libraries.This depends on the corresponding Courier PR, here: bigladder/courier#6