Skip to content

feat(payment): PAYPAL-6318 Update paypal sdk namespace for BCP paypalsdk config with bigCommercePayments naming#3174

Merged
serhiiFilkovskyi merged 1 commit intomasterfrom
PAYPAL-6318
Mar 12, 2026
Merged

feat(payment): PAYPAL-6318 Update paypal sdk namespace for BCP paypalsdk config with bigCommercePayments naming#3174
serhiiFilkovskyi merged 1 commit intomasterfrom
PAYPAL-6318

Conversation

@serhiiFilkovskyi
Copy link
Contributor

@serhiiFilkovskyi serhiiFilkovskyi commented Mar 10, 2026

What/Why?

Updates PayPal SDK script-loading configs with

  • paypal -> bigCommercePaymentsPayPalSDK
  • paypalFastlane ->bigCommercePaymentsFastlane
  • paypalFastlaneSdk ->bigCommercePaymentsFastlaneSdk
  • paypalMessages ->bigCommercePaymentsMessages
  • paypalApms ->bigCommercePaymentsApms
  • paypalGooglePay -> bigCommercePaymentsGooglePay

Rollout/Rollback

Rollout

Testing

BCP:

Screen.Recording.2026-03-12.at.10.14.16.mov

PPCP:

PPCP.mov

Note

Medium Risk
Changes the data-namespace used when loading multiple PayPal SDK variants, which can affect global SDK naming and any code that references the previous namespaces. Blast radius is limited to PayPal/BCP script-loading paths and is covered by updated unit tests.

Overview
Updates PayPal SDK script-loading configs to consistently pass a BigCommerce Payments-specific data-namespace.

BigCommercePaymentsScriptLoader now always sets data-namespace: bigCommercePaymentsPayPalSDK (and the script params types allow this attribute), and PayPalSdkHelper renames namespaces for Fastlane/Messages/Google Pay/APMs to bigCommercePayments*. Related unit tests are updated to assert the new namespaces, including the case where other attributes are omitted.

Written by Cursor Bugbot for commit 9086795. This will update automatically on new commits. Configure here.

@serhiiFilkovskyi serhiiFilkovskyi self-assigned this Mar 10, 2026
@serhiiFilkovskyi serhiiFilkovskyi force-pushed the PAYPAL-6318 branch 2 times, most recently from 2be32d2 to bdefcc9 Compare March 11, 2026 09:54
@serhiiFilkovskyi serhiiFilkovskyi marked this pull request as ready for review March 11, 2026 15:21
@serhiiFilkovskyi serhiiFilkovskyi requested a review from a team as a code owner March 11, 2026 15:21
@serhiiFilkovskyi serhiiFilkovskyi force-pushed the PAYPAL-6318 branch 2 times, most recently from 512d347 to 9086795 Compare March 11, 2026 16:27
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@serhiiFilkovskyi serhiiFilkovskyi marked this pull request as draft March 11, 2026 17:36
… sdk config with bigcommerce-payments naming
@serhiiFilkovskyi serhiiFilkovskyi force-pushed the PAYPAL-6318 branch 2 times, most recently from 6ee56bf to 51a41bd Compare March 12, 2026 08:37
@serhiiFilkovskyi serhiiFilkovskyi marked this pull request as ready for review March 12, 2026 08:42
Copy link
Contributor

@serhii-tkachenko serhii-tkachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@serhii-tkachenko serhii-tkachenko changed the title feat(payment): DRAFT PAYPAL-6318 Update paypal sdk namespace for BCP paypalsdk config with bigcommerce-payments naming feat(payment): PAYPAL-6318 Update paypal sdk namespace for BCP paypalsdk config with bigcommerce-payments naming Mar 12, 2026
@serhii-tkachenko serhii-tkachenko changed the title feat(payment): PAYPAL-6318 Update paypal sdk namespace for BCP paypalsdk config with bigcommerce-payments naming feat(payment): PAYPAL-6318 Update paypal sdk namespace for BCP paypalsdk config with bigCommercePayments naming Mar 12, 2026
@serhiiFilkovskyi serhiiFilkovskyi merged commit 2b0feb0 into master Mar 12, 2026
8 checks passed
@serhiiFilkovskyi serhiiFilkovskyi deleted the PAYPAL-6318 branch March 12, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants