DnD support for custom EventWrapper#880
Merged
Merged
Conversation
Fixed all hardcoded `defaultView` prop strings to use the Views constants
- Pass through range and value props to match non-dnd component props - Added `customComponents` utility file for use with stories - Clarified comment in `withDragAndDrop`
jquense
approved these changes
Jun 18, 2018
jquense
left a comment
jquense
left a comment
Collaborator
There was a problem hiding this comment.
looks good thanks a ton 👍
Collaborator
|
Thanks, @amkoehler for your great improvements the early DnD work! Much appreciated! |
arecvlohe
approved these changes
Jun 19, 2018
Contributor
Author
|
@ehahn9 anytime. You did the hard part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work I did on #843.
When testing out the dnd addon I found this note in a comment in
withDragAndDrop.js:With #843 we added support for
DayWrapperandDateCellWrappercomponents. This PR continues that work and adds support for custom EventWrapper components. In hindsight I wish I had done this as part of that PR because it was a lot simpler than I thought it'd be.Added stories for custom eventWrapper and custom eventWrapper with DnD.