Skip to content

Bug with listeners in Selection.teardown method #2072

Description

@vmstarchenko

Bug report

I am not sure but visually there is a bug with Selection.teardown method. Everywhere in this file variable _listeners is used but in teardown method it doesn't starts with underscore:
this._listeners = Object.create(null)
vs
this.listeners = Object.create(null)

(https://github.com/jquense/react-big-calendar/blob/master/src/Selection.js#L47 vs https://github.com/jquense/react-big-calendar/blob/master/src/Selection.js#L102)

It might cause a problem with event listeners unbinding.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions