Sanitize raw HTML content and fix replies #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Notices that replies are currently still displayed as HTML code, so I (tried to) fix that, too. |
defnull
force-pushed
the
develop
branch
4 times, most recently
from
563b567 to
ad10bf7
Compare
While we usually can trust chat messages to originate from 'save' Markdown, it's still best practice to never inject user provided HTML directly into the DOM. This patch also fixes visible HTML code in relies.
defnull
changed the title
gustavotrott
approved these changes
Dec 9, 2025
Collaborator
gustavotrott
left a comment
gustavotrott
left a comment
There was a problem hiding this comment.
lgtm! thanks @defnull
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we usually can trust chat messages to originate from 'save' Markdown, it's still best practice to never inject user provided HTML directly into the DOM.