Added option 'emitWarnings' to identify unprocessed files#150
Added option 'emitWarnings' to identify unprocessed files#150Root-Core wants to merge 2 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 100% 93.75% -6.25%
==========================================
Files 1 1
Lines 28 32 +4
Branches 10 12 +2
==========================================
+ Hits 28 30 +2
- Misses 0 2 +2
Continue to review full report at Codecov.
|
|
Thanks for your PR! Code looks great. Can you add some tests to make codecov happy? Also I am curious if it is possible to see the name of the file in the warning message. Message will be much more informative if it will contain the name of the file for which svg-url-loader felt back to file-loader. |
|
I can look into it, tough I dont't really know how this could be tested. The file name seems to be unavailable and not necessary too, as webpack shows warnings emited via |
|
@Root-Core , then add some tests and I'll be happy to merge your PR. Regarding tests. Perhaps it will be possible to setup a spy on emitWarning() method. |
Hello there,
as we have two options, which will prevent processing of files, we should have an option to identify these unprocessed files.
You might consider to default this to true or warn without the option, as it should be useful in most cases.
I could do this, if you give me some feedback. 👍
Regards!