Drop the serde_json dependency #24
Open
+572
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies of this crate now use `const_fn` which requires 1.46.0. Signed-off-by: Nathaniel McCallum <[email protected]>
```
warning: this seems like a manual implementation of the non-exhaustive pattern
--> src/error.rs:11:1
|
11 | pub enum Error {
| ^-------------
| |
| _help: add the attribute: `#[non_exhaustive] pub enum Error`
| |
12 | | ParseError {
13 | | msg: String,
14 | | line: usize,
... |
45 | | __NonExhaustive,
46 | | }
| |_^
|
= note: `#[warn(clippy::manual_non_exhaustive)]` on by default
help: remove this variant
--> src/error.rs:45:5
|
45 | __NonExhaustive,
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive
warning: 1 warning emitted
```
Signed-off-by: Nathaniel McCallum <[email protected]>
```
error: this expression borrows a reference (`&std::string::String`) that is immediately dereferenced by the compiler
--> src/error.rs:114:44
|
114 | Error::GenericError { msg } => &msg,
| ^^^^ help: change this to: `msg`
|
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: for further information visit rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: aborting due to previous error
```
Signed-off-by: Nathaniel McCallum <[email protected]>
This implements an internal `Value` type which functions like `serde_json::Value`. Note that because this commit changes the `Error` type, this is an API-breaking change. Resolves: bheisler#1 Signed-off-by: Nathaniel McCallum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an internal
Valuetype which functions likeserde_json::Value. Note that because this commit changes theErrortype, this is an API-breaking change.Resolves: #1