Added maximum iterations option #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infinite loop could happen for some distance functions. This caps the maximum number of iterations to 1e3 by default, or allows override using the <iteration_max> parameter
dhermes
reviewed
Feb 15, 2017
| #----------------------------------------------------------------------------- | ||
|
|
||
| def distmesh2d(fd, fh, h0, bbox, pfix=None, fig='gcf'): | ||
| def distmesh2d(fd, fh, h0, bbox, pfix=None, fig='gcf', iteration_max=1e3): |
Collaborator
There was a problem hiding this comment.
Nit: 1e3 is a float but you really want an int here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infinite loop could happen for some distance functions. This caps the
maximum number of iterations to 1e3 by default, or allows override
using the <iteration_max> parameter