This repository was archived by the owner on Feb 1, 2018. It is now read-only.
Allow load custom scheme with ENV['SCHEME'].#30
Closed
linjunpop wants to merge 1 commit intobendyworks:masterfrom
Closed
Allow load custom scheme with ENV['SCHEME'].#30linjunpop wants to merge 1 commit intobendyworks:masterfrom
linjunpop wants to merge 1 commit intobendyworks:masterfrom
Conversation
Contributor
|
@linjunpop Thanks for taking the time to create a PR... I really appreciate it! I'm not, however, going to pull this in exactly as is. Per the discussion in #21 (for which this issue is a duplicate), we'll be switching away from So, this functionality will be in the next release, but not exactly as you coded it up. I'm going to close this as a dupe of #21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.