[Bug]: Ignores files it shouldnt ignore when negative patterns are used

[janthomasQS]

Description

Assume a repo with the following .csharpierignore

/*
!/CsharpierIngoreTest/IncludedSourceFolder/IncludedClass.cs

The intention is to exclude everyhing except specific files or folders because not the entire company wants to use csharpier on their code.

With the newest version csharpier will ignore the file that was included previously.
If this is intentional then how would i specify this situation instead? I honestly cannot find a way that works

PS B:\sgit\source\Playground\> dnx --version 1.0.0 csharpier format . --log-level Trace
Formatting - .\CsharpierIngoreTest\IncludedSourceFolder\IncludedClass.cs
Formatted 1 files in 1586ms.
PS B:\sgit\source\Playground\> dnx --version 1.2.5 csharpier format . --log-level Trace
Formatted 0 files in 598ms.

Steps to Reproduce

Create a csharpierignore with the specified content

Expected Behavior

It formats the files i included

Actual Behavior

It does not

[belav]

CSharpier changed recently so that the ignore rules work the exact same way that gitignore rules. I didn't realize my initial implementation of them was missing a lot of edge cases. The big change was

It is not possible to re-include a file if a parent directory of that file is excluded.

Because /* is ignoring all directories, it looks like you need to re-include each of the parents with a separate rule. This seemed to work for me

/*
!/CsharpierIngoreTest/
!/CsharpierIngoreTest/IncludedSourceFolder/
!/CsharpierIngoreTest/IncludedSourceFolder/IncludedClass.cs

[janthomasQS]

Interstingly the exact snippet you sent does not work for me despite all paths being correct. But having to list all parents is inpractical anyways because i would have to maintain thousands of patterns that way.

I did actually find a way now that works when used in a gitignore but does not when using it in csharpier. If you create a gitignore with this content all files outside IncludedSourceFolder are gitignored. If you use the same content for .csharpierignore it does not format anything. It doesnt look like the nicest solution performance-wise though as it would have to traverse all folders as far as i understand

*
!*/
!/CsharpierIngoreTest/IncludedSourceFolder/**/*.cs

[belav]

My testing shows that new pattern is also working the same between git and csharpier. https://github.com/belav/csharpier/pull/1806/changes

If you create a reproduction repo, maybe there is something else going on that I'm not seeing with my tests.

[janthomasQS]

This is the folder structure and gitignore i have:
You can see the file IncludedClass.cs is not gitignored. This can be validated with git check-ignore as well.

Now create an identical .csharpierignore and delete the .gitignore and run dnx --version 1.2.6 csharpier format . in the root of the repository. No file will be formatted. If you explicitly name the file to be formatted with the following command then it will actually format the file. dnx --version 1.2.6 csharpier format . .\CsharpierIngoreTest\IncludedSourceFolder\IncludedClass.cs

[belav]

Thanks for that, I can see reproduce the problem now.