Skip to content

Resolve B904#2515

Merged
mhsmith merged 11 commits intobeeware:mainfrom
NMertsch:resolve-b904
Oct 20, 2025
Merged

Resolve B904#2515
mhsmith merged 11 commits intobeeware:mainfrom
NMertsch:resolve-b904

Conversation

@NMertsch
Copy link
Contributor

@NMertsch NMertsch commented Oct 18, 2025

Resolve ruff rule B904 - raise-without-from-inside-except.

This PR build on the stale PR #2476 by @cgkoutzigiannis. It only contains a rebase and adds 235dd9b, which addresses the changes requested by @mhsmith. See #2476 for related comments.

Fixes #2381.
Closes #2476.

PR Checklist:

@NMertsch
Copy link
Contributor Author

I don't think the CI failure is caused by this PR (HTTPSConnectionPool(host='flathub.org', port=443): Read timed out).

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flagged a handful of cases where chaining isn't providing any additional context; with those cleaned up this should be good to land.

@mhsmith mhsmith mentioned this pull request Oct 20, 2025
4 tasks
@mhsmith mhsmith merged commit 03c7170 into beeware:main Oct 20, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve BXXX series ignored Ruff rules

4 participants