Skip to content

fix: toga gui bootstrap imports#2402

Merged
freakboy3742 merged 3 commits intobeeware:mainfrom
amfibio:fix_toga_gui_bootstrap
Jul 19, 2025
Merged

fix: toga gui bootstrap imports#2402
freakboy3742 merged 3 commits intobeeware:mainfrom
amfibio:fix_toga_gui_bootstrap

Conversation

@amfibio
Copy link
Contributor

@amfibio amfibio commented Jul 19, 2025

This removes the from toga.style import Pack import from the TogaGuiBootstrap as it is no longer needed for the minimal (stub) application. The relevant unit test was adjusted.

The relevant tutorial on what was generated already does not include the import as expected. At the same time, the tutorial mentions the Pack object, including the import as an advanced technique via a note.

There is no PR.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@amfibio amfibio marked this pull request as draft July 19, 2025 13:11
@amfibio amfibio marked this pull request as ready for review July 19, 2025 14:14
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the cleanup!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change note is good; but it's a misc, not a removal - removals are for backwards incompatible changes.

@freakboy3742 freakboy3742 merged commit 1462b8c into beeware:main Jul 19, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants