Change test_mode to an app property#2327
Merged
freakboy3742 merged 4 commits intobeeware:mainfrom Jun 5, 2025
Merged
Conversation
freakboy3742
approved these changes
Jun 5, 2025
Member
freakboy3742
left a comment
There was a problem hiding this comment.
It's a big change, but I think the shape of the changes that have been required in the test suite indicates it's the right move - it's mostly removing test_mode context from places where it isn't really relevant, so we can inject it explicitly in the handful of places where it matters.
Thanks for taking this on - most appreciated!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the
test_modeFlag becomes a property of theAppConfigas suggested in #2173 (review). This simplifies the code, astest_modeis only required at a few points and no longer has to be passed through all functions.This refactoring simplifies adding a new
debug_modein #2173.PR Checklist: