Use the system certificate store for downloads, where possible.#2308
Merged
mhsmith merged 4 commits intobeeware:mainfrom May 22, 2025
Merged
Use the system certificate store for downloads, where possible.#2308mhsmith merged 4 commits intobeeware:mainfrom
mhsmith merged 4 commits intobeeware:mainfrom
Conversation
mhsmith
reviewed
May 21, 2025
Comment on lines
+103
to
+105
| @property | ||
| def ssl_context(self): | ||
| """The SSL context to use for downloads.""" |
Member
There was a problem hiding this comment.
Can we add a test that this function returns the correct value or type?
mhsmith
approved these changes
May 21, 2025
Member
mhsmith
left a comment
mhsmith
left a comment
There was a problem hiding this comment.
Approved, assuming the CI passes.
kingRoyalty-100
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the use of
truststorewhen performing downloads in Briefcase. This should hopefully avoid the issues with the use of proxies and VPNs. httpx uses certifi as a trust store by default; but corporate proxy/VPN configurations often involve manipulation of the system trust store. This leads to situations where a URL can be reached by a browser, but not by Briefcase. Usingtruststoremeans that Briefcase will have the same trust configuration as the browser.Fixes #2296.
PR Checklist: