Correct pip usage and notarization logging.#2149
Merged
mhsmith merged 2 commits intobeeware:mainfrom Feb 6, 2025
Merged
Conversation
mhsmith
approved these changes
Feb 6, 2025
Member
mhsmith
left a comment
There was a problem hiding this comment.
pip 25.1 will enforce this behaviour change
I've asked them about the fact that this appears to be earlier than their deprecation policy allows.
Given the 25.1 release could happen at any time
It looks like they still have a long list in the milestone, so it probably isn't imminent.
Member
Author
True - but given we're prone to months between releases, it would be easy to be bitten by pip releasing before our own informal release process decides it's time for 0.3.21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 2 small issues:
--no-python-version-warning. pip 25.0 displays the following warning if it is used:quiet=1to two uses ofparse_outputin the notarization code. When we introduced Surface raw errors when check_output fails #2125, we addedquiet=1to all uses ofcheck_output()where a error code was normal expected operation, and added a call tooutput_error()if the error received wasn't an expected value. We audited the code for allcheck_output()calls... but forgot thatparse_output()builds oncheck_output(). The notarisation code includes 2 such uses; there are no others that I can find.Given the 25.1 release could happen at any time, it may be advisable to push out a new release after merging this PR. The quiet=1 fix isn't a major issue, but it would be nice to clean up at the same time.
PR Checklist: