Skip to content

Fix documentation of macOS entitlements configuration to make it clear that lists and dictionaries are also valid.#1863

Merged
freakboy3742 merged 4 commits intobeeware:mainfrom
michelcrypt4d4mus:fix_entitlements_doc
Jun 7, 2024
Merged

Fix documentation of macOS entitlements configuration to make it clear that lists and dictionaries are also valid.#1863
freakboy3742 merged 4 commits intobeeware:mainfrom
michelcrypt4d4mus:fix_entitlements_doc

Conversation

@michelcrypt4d4mus
Copy link

Tested this out personally after @freakboy3742 told me the documentation was wrong.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; but the PR needs a changenote

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've downgraded the change note to a misc, as a minor correction doesn't really warrant a full callout in the release notes; but otherwise, this looks good - thanks!

@freakboy3742 freakboy3742 merged commit f05f017 into beeware:main Jun 7, 2024
@michelcrypt4d4mus michelcrypt4d4mus deleted the fix_entitlements_doc branch June 7, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants